-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring (No functional changes) #7513
Conversation
atiq-bs23
commented
Jan 24, 2025
•
edited
Loading
edited
- Removed unused variables.
- Included reference in ascending order.
- Adjusted spaces/alignments.
@atiq-bs23 Thanks for your help. How did you find all these places, manually or by some code analysis utilities? |
@RomanovM Have you thought about using a github action workflow to run linting check on new PRs so that this is taken care of automatically? |
Okay 👍 |
@RomanovM yes, using visual studio code cleanup. |
@RomanovM This process affected many files, mostly by changing their size. However, I noticed a few files that had meaningful changes, such as adjustments to spacing and alignment, sorting using references in ascending order, and removing unused references. I included only these meaningful changes in the commit. |
@RomanovM While manually checking the changed files, I missed a few of them. I’ve now found the ones I missed. Should I include those in a pull request? |
@atiq-bs23 You can create a new pull request |